refactor(components/widget): extract amount component#704
Merged
Conversation
sidvishnoi
force-pushed
the
widget-amount-component
branch
from
632e40a to
06abb29
Compare
Deployment results
Logs #25552015882 |
6 tasks
sidvishnoi
force-pushed
the
widget-amount-component
branch
from
06abb29 to
a7e295c
Compare
sidvishnoi
force-pushed
the
widget-amount-component
branch
from
a7e295c to
f7fbb62
Compare
sidvishnoi
force-pushed
the
widget-amount-component
branch
from
f7fbb62 to
64e9cb7
Compare
DarianM
approved these changes
May 8, 2026
DarianM
left a comment
DarianM
left a comment
Member
There was a problem hiding this comment.
Tested. looks good. much improved. a small improvement nit. if I hit Delete and type the exact same amount again in the input field, it shouldn't fetch quote because I already have it for that amount.
Member
Author
Good catch. Will look into caching in general, not just on last amount, as a follow-up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #696
Cleanup opportunity for future: create a base.css which includes some common styles that we use across components. Right now, I'm importing confirmation.css as some
.form-fieldstyles are used in this amount as well as "Note" input.